Changes to allow cylinders - and other cuboids - to go down#197
Open
kellyfj wants to merge 1 commit intowalterhiggins:masterfrom
Open
Changes to allow cylinders - and other cuboids - to go down#197kellyfj wants to merge 1 commit intowalterhiggins:masterfrom
kellyfj wants to merge 1 commit intowalterhiggins:masterfrom
Conversation
Owner
|
Hey @kellyfj , If you want to build down, then why not move down first then build up? /js down(40).cylinder(blocks.air,5,40) |
Owner
|
hmmm. I think I see what you mean - you can do it by moving the drone first but using negative values for width, height and depth is more concise. I'll look at this some more. |
Owner
|
I reckon if we go this route (negative distances) we'll have to do it for height, width and depth and update the docs accordingly. Will have a think about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Walter,
I was trying to create a new function like cylinder.js but that would create a hole in the ground. I traced cylinder --> arcImpl down to traverseHeight and noticed I could not pass a negative height in.
Would love some feedback on whether this approach makes sense or if you would do something different.
With this change I can now do
/js cylinder(blocks.air,5,-40)to make a hole with radius 5 and 40 blocks deep
Best,
-Frank